Conversation
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| clear: { | ||
| control: { type: 'boolean' }, | ||
| }, | ||
| defaultValue: { |
There was a problem hiding this comment.
When I try to enter a value here not getting any change in the example. Tested passing "small" here.
There was a problem hiding this comment.
okay let me look
There was a problem hiding this comment.
I took out it wasnt coming through correct
| control: { type: 'text' }, | ||
| }, | ||
| disabled: disabledArg, | ||
| name: { |
There was a problem hiding this comment.
Feel like we don't need to include the name prop since it doesn't demo well in storybook
| control: { type: 'object' }, | ||
| }, | ||
| placeholder: placeholderArg, | ||
| size: textSizesArg, |
There was a problem hiding this comment.
Wondering if we want people to be adjusting the size of the select or not.
@grommet/design is it okay for people within hpe to change the size of a select component?
3 participants
Deploy Preview
What does this PR do?
adds select story
What are the relevant issues?
related to #5710
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?